search

GoogleCloudPlatform / guest-oslogin

OS Login Guest Environment for Google Compute Engine
https://cloud.google.com/compute/docs/oslogin/
Apache License 2.0
95 stars 47 forks source link

take metadata endpoint from config file #127

Open IlyaMar opened 8 months ago

IlyaMar commented 8 months ago

Read metadata endpoint from /etc/google_oslogin.conf. Use default 169.254.169.254 if config not found or not readable. Read config once on .so load.

google-oss-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IlyaMar Once this PR has been reviewed and has the lgtm label, please assign chaitanyakulkarni28 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/guest-oslogin/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 8 months ago

Hi @IlyaMar. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dorileo commented 6 months ago

Hi @IlyaMar what are you trying to achieve wit this change? How would a user benefit from this feature? What would be the use case?

Thanks, Leo

IlyaMar commented 5 months ago

Hi @IlyaMar what are you trying to achieve wit this change? How would a user benefit from this feature? What would be the use case?

Thanks, Leo

Hi Leo, sorry for a long delay. This is not for a user, rather for a developer to be able to test component against a mock endpoint that listens on localhost. Another possible case is migration to a new endpoint to avoid old endpoint shutdown and oslogin downtime.