search

GoogleCloudPlatform / guest-oslogin

OS Login Guest Environment for Google Compute Engine
https://cloud.google.com/compute/docs/oslogin/
Apache License 2.0
96 stars 47 forks source link

Update packaging as of Ubuntu devel packaging #130

Open utkarsh2102 opened 9 months ago

utkarsh2102 commented 9 months ago

Hello,

This PR is an initiative to align the Debian packaging of guest-oslogin in Ubuntu and upstream (here).

The diff represents the changes we have in Ubuntu. I'm forwarding them here as they're all relevant and follow the standard Debian packaging practices. These changes are what we have in Ubuntu devel (current development branch).

These changes change how packaging is done and don't affect the resulting binaries (that is, there is no functional change).

Please let me know if you have any questions or concerns.

google-oss-prow[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: utkarsh2102 Once this PR has been reviewed and has the lgtm label, please assign chaitanyakulkarni28 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/guest-oslogin/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 9 months ago

Hi @utkarsh2102. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
utkarsh2102 commented 1 month ago

@dorileo @a-crate, hey, this is ready for your review! :)

a-crate commented 1 month ago

LGTM. @dorileo ?