GoogleCloudPlatform / guest-oslogin

OS Login Guest Environment for Google Compute Engine
https://cloud.google.com/compute/docs/oslogin/
Apache License 2.0
95 stars 47 forks source link

pam: bring back pam's account management implementation #133

Closed dorileo closed 6 months ago

dorileo commented 6 months ago

With this change users can get back to using these pam modules for their own custom pam configurations in a way to differentiate oslogin users (i.e. reported issue #123).

PS: These modules will not be automatically added to google's managed pam configurations by guest-agent.

google-oss-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dorileo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/guest-oslogin/blob/master/OWNERS)~~ [dorileo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dorileo commented 6 months ago

/hold

dorileo commented 6 months ago

Is there a matching change to the Guest Agent? How will this PAM module be installed and managed?

The answer is in the commit message but I agree it's worth mentioning in the code:

With this change users can get back to using these pam modules for their own custom pam configurations in a way to differentiate oslogin users (i.e. reported issue https://github.com/GoogleCloudPlatform/guest-oslogin/issues/123). PS: These modules will not be automatically added to google's managed pam configurations by guest-agent.

dorileo commented 6 months ago

@ericdand

I added documentation to each of the functions mentioning the intended usage and that Guest Agent will not manage it's configuration. As to the other comments I resolved them since they don't apply.

Thanks, Leo

ericdand commented 6 months ago

Nice, that doc comment is great and clarifies a lot. I left a little note about the error messages in review; otherwise LGTM.

ericdand commented 6 months ago

/lgtm

dorileo commented 6 months ago

/unhold