search

GoogleCloudPlatform / guest-oslogin

OS Login Guest Environment for Google Compute Engine
https://cloud.google.com/compute/docs/oslogin/
Apache License 2.0
95 stars 47 forks source link

Log an error when user has no challenges configured #135

Open mattiasa opened 5 months ago

mattiasa commented 5 months ago

Improves logging when a user doesn't have any 2FA methods configured for their Google account.

Fixes #134

google-cla[bot] commented 5 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattiasa Once this PR has been reviewed and has the lgtm label, please assign bkatyl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/guest-oslogin/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 5 months ago

Hi @mattiasa. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
a-crate commented 4 months ago

@mattiasa Can you sign the CLA for this?

mattiasa commented 4 months ago

@mattiasa Can you sign the CLA for this?

Yes, just trying to get all the legal ducks in line for that.

a-crate commented 2 months ago

/lgtm /test all

a-crate commented 2 months ago

Leo or Chaitanya can you review as well? /cc @dorileo @ChaitanyaKulkarni28