cache_oslogin binary should not log empty

GoogleCloudPlatform / guest-oslogin

OS Login Guest Environment for Google Compute Engine

https://cloud.google.com/compute/docs/oslogin/

Apache License 2.0

96 stars 47 forks source link

Open hopkiw opened 3 years ago

hopkiw commented 3 years ago

when OS Login is not enabled, there's no need to log that we failed to populate the cache file

illfelder commented 3 years ago

Based on issues that came up recently, we should ideally update the logic with the following behaviors:

When the metadata server returns an unsuccessful error code, we should not log (OS Login is not enabled).
When the metadata server returns no users or groups, but returns successfully, we should create the cache file with no entries. We also should not log warning messages.

hopkiw commented 3 years ago

the 404 case where oslogin is disabled is fixed in #52 we still need to handle the 'empty groups' case to not log