Merging new DICOM IO connector changes with Beam Repository

GoogleCloudPlatform / healthcare-data-harmonization-dataflow

Apache License 2.0

35 stars 24 forks source link

Merging new DICOM IO connector changes with Beam Repository #4

Closed Aliraza-N closed 3 years ago

Aliraza-N commented 3 years ago

Changes:

new DICOM IO connector is created that allows DICOM API to be used by Beam
New methods in existing Healthcare API client class

Aliraza-N commented 3 years ago

@lastomato How do these changes look?

Aliraza-N commented 3 years ago

There is an open PR in that repo for the same changes. I'll go back and update these new changes there as well.

Aliraza-N commented 3 years ago

@lastomato Ready for review please

lastomato commented 3 years ago

There is an open PR in that repo for the same changes. I'll go back and update these new changes there as well.

Please make sure to add integration tests to that PR.

Aliraza-N commented 3 years ago

There is an open PR in that repo for the same changes. I'll go back and update these new changes there as well.

Please make sure to add integration tests to that PR.

Yes, there are already IT in that repo for DICOM IO

dranderson1117 commented 3 years ago

Nice job Aliraza - LGTM