Closed Aliraza-N closed 3 years ago
Hi, this PR is for the DICOM to FHIR pipeline. Could you please review it? I've mentioned the new files in the description. @lastomato @dranderson1117
I just realized I misclicked approve earlier this afternoon, I didn't find a way to unapprove, so I requested another review for myself. Sorry for the confusion.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
ℹ️ Googlers: Go here for more info.
LGTM
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
ℹ️ Googlers: Go here for more info.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
ℹ️ Googlers: Go here for more info.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
ℹ️ Googlers: Go here for more info.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
ℹ️ Googlers: Go here for more info.
New files in this PR: src/main/java/com/google/cloud/healthcare/etl/runner/dicomtofhir/DicomToFhirStreamingRunner.java src/main/java/com/google/cloud/healthcare/etl/model/mapping/HclsApiDicomMappableMessage.java src/main/java/com/google/cloud/healthcare/etl/model/mapping/HclsApiDicomMappableMessageCoder.java
The others were already reviewed as part of another PR