GoogleCloudPlatform / healthcare-data-harmonization-dataflow

Apache License 2.0
35 stars 24 forks source link

New pipeline branch #5

Closed Aliraza-N closed 3 years ago

Aliraza-N commented 3 years ago

New files in this PR: src/main/java/com/google/cloud/healthcare/etl/runner/dicomtofhir/DicomToFhirStreamingRunner.java src/main/java/com/google/cloud/healthcare/etl/model/mapping/HclsApiDicomMappableMessage.java src/main/java/com/google/cloud/healthcare/etl/model/mapping/HclsApiDicomMappableMessageCoder.java

The others were already reviewed as part of another PR

Aliraza-N commented 3 years ago

Hi, this PR is for the DICOM to FHIR pipeline. Could you please review it? I've mentioned the new files in the description. @lastomato @dranderson1117

lastomato commented 3 years ago

I just realized I misclicked approve earlier this afternoon, I didn't find a way to unapprove, so I requested another review for myself. Sorry for the confusion.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

poojavenkatram commented 3 years ago

@googlebot I signed it!

google-cla[bot] commented 3 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

dranderson1117 commented 3 years ago

LGTM

google-cla[bot] commented 3 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.