search

GoogleCloudPlatform / healthcare-dicom-dicomweb-adapter

Adapter which transforms DIMSE requests to DICOMweb requests
Apache License 2.0
119 stars 48 forks source link

Failed - Building from source #129

Open ramirocorletti opened 3 years ago

ramirocorletti commented 3 years ago

When completing steps under building from source: https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter#building-from-source

We get the following error:

Configure project :import Evaluating project ':import' using build file 'C:\healthcare-dicom-dicomweb-adapter-master\import\build.gradle'. Adding license extension Adding download licenses extension Applying defaults to download task: :import:downloadLicenses Adding licenseMain task for sourceSet main Applying license defaults to task: :import:licenseMain Applying license defaults to task: :import:licenseFormatMain Adding licenseTest task for sourceSet test Applying license defaults to task: :import:licenseTest Applying license defaults to task: :import:licenseFormatTest Default docker.url set to tcp://127.0.0.1:2375 Applying defaults to download task: :import:downloadOpensSourceLicenses Resource missing. [HTTP GET: https://repo.maven.apache.org/maven2/com/github/jai-imageio/jai-imageio-jpeg2000/1.3.1-dicomadapter/jai-imageio-jpeg2000-1.3.1-dicomadapter.pom] Resource missing. [HTTP GET: https://www.dcm4che.org/maven2/com/github/jai-imageio/jai-imageio-jpeg2000/1.3.1-dicomadapter/jai-imageio-jpeg2000-1.3.1-dicomadapter.pom] Resource missing. [HTTP GET: https://jitpack.io/com/github/jai-imageio/jai-imageio-jpeg2000/1.3.1-dicomadapter/jai-imageio-jpeg2000-1.3.1-dicomadapter.pom] All projects evaluated.

FAILURE: Build failed with an exception.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.8.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 8s

danielbeaudreau commented 3 years ago

Sometimes fetching the dependencies is flaky because the build script downloads them from the internet. Could you please retry?

ramirocorletti commented 3 years ago

Thanks @danielbeaudreau for your response. I retried several times and the error persists. I belive it might have something to do with the syntax:

What went wrong: Project '.args=--dimse_aet=IMPORTADAPTER --dimse_port=4008 --dicomweb_address=https' not found in root project 'healthcare-dicom-dicomweb-adapter-master'.

danielbeaudreau commented 3 years ago

What version of gradle are you using? Can you try running just "gradle build" https://github.com/GoogleCloudPlatform/healthcare-dicom-dicomweb-adapter#building-from-source

ramirocorletti commented 3 years ago

Gradle build builds succesfuly

PS C:\healthcare-dicom-dicomweb-adapter-master\import> gradle build Starting a Gradle Daemon, 2 incompatible Daemons could not be reused, use --status for details

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.8.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 24s 21 actionable tasks: 1 executed, 20 up-to-date

PS C:\healthcare-dicom-dicomweb-adapter-master\import> gradle -v

Gradle 6.8.3

Build time: 2021-02-22 16:13:28 UTC Revision: 9e26b4a9ebb910eaa1b8da8ff8575e514bc61c78

Kotlin: 1.4.20 Groovy: 2.5.12 Ant: Apache Ant(TM) version 1.10.9 compiled on September 27 2020 JVM: 11.0.10 (AdoptOpenJDK 11.0.10+9) OS: Windows 10 10.0 amd64

danielbeaudreau commented 3 years ago

Could you paste the failing command please?

ramirocorletti commented 3 years ago

PS C:\healthcare-dicom-dicomweb-adapter-master\import> gradle run -Dorg.args="--dimse_aet=IMPORTADAPTER --dimse_port=4008 --dicomweb_address=https://healthcare.googleapis.com/v1/projects/xxxxx/locations/xxxxx/datasets/xxxxx/dicomStores/xxxxx/dicomWeb"

danielbeaudreau commented 3 years ago

Could you try Dexec.args instead of Dorg.args?

ramirocorletti commented 3 years ago

Yes, sorry, I am using Decec.args not Dorg, the previous message was a typo from another test, the command line I am using is:

PS C:\healthcare-dicom-dicomweb-adapter-master\import> gradle run -Dexec.args="--dimse_aet=IMPORTADAPTER --dimse_port=4008 --dicomweb_address=https://healthcare.googleapis.com/v1/projects/xxxxx/locations/xxxxx/datasets/xxxxx/dicomStores/xxxxx/dicomWeb"

danielbeaudreau commented 3 years ago

I ran gradle run -Dexec.args="--dimse_aet=IMPORTADAPTER --dimse_port=4008 --dicomweb_address=http://localhost:80" in the import directory and it worked for me, it must be something with your environment. I wonder if it is due to running on Windows?

Could you try running gradle clean and then running the command again?

danielbeaudreau commented 3 years ago

If that does not work could you run with --stacktrace option and paste the output?

ramirocorletti commented 3 years ago

If it works for you might be something within my environment. Below find the stacktrace output in case something comes up. If not I can build a linux env and retry:

PS C:\healthcare-dicom-dicomweb-adapter-master\import> gradle run -Dexec.args="--dimse_aet=IMPORTADAPTER --dimse_port=4008 --dicomweb_address=https://healthcare.googleapis.com/v1/projects/xxxxx/locations/xxxxx/datasets/xxxx/dicomStores/xxxxx/dicomWeb" --stacktrace

FAILURE: Build failed with an exception.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.8.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 9s

danielbeaudreau commented 3 years ago

Seems like gradle is searching for the args as the task, but it should know that "run" is the desired task to execute. Could you try on linux and see if that works?

maxirodr commented 3 years ago

Hello @danielbeaudreau, we're trying with @ramirocorletti to test it from Ubuntu 18.04, and it's impossible for me to run the build:

imagen

with this:

imagen

danielbeaudreau commented 3 years ago

Please use an older version of gradle below 7. Gradle made some breaking changes in v7 that broke our build.

maxirodr commented 3 years ago

Working perfect with Gradle 6.6, in Ubuntu 18.04 with latests releases (java, sdk, etc). Maybe need to detail about Gradle 6.6 as prefered version in the building of the repo (locally). Thanks for the help @danielbeaudreau

danielbeaudreau commented 3 years ago

Glad it worked. If I get some time, would like to fix the build to work with both v7 and v6.

maxirodr commented 3 years ago

@danielbeaudreau Daniel, sorry i bother you again. I don't know what are the scopes I need to select in GCP to let me storage into it:

imagen

i'm trying to send DCM file from SCU Emulator to the Adapter:

imagen

danielbeaudreau commented 3 years ago

Could you try specifying the flag 

--oauth_scopes=https://www.googleapis.com/auth/cloud-platform
maxirodr commented 3 years ago

@danielbeaudreau Daniel, perfect. I've added the remaining params to make it work to IAM (GCP) using the same credentials and now it work perfect. The adapter is forwarding the DCM files. Just one thing is showing now and I don't know about what is referring to:

imagen

Anyway, is working.

maxirodr commented 3 years ago

@danielbeaudreau hello Daniel, how are you? We're trying now to run the same in Windows 10. I've setup the same dependencies in Linux and we've some troubles to run. "gradle build" works okay, and have built without problems, the problem is the other command, to run the adapter:

gradle_1

gradle_2

gradle_3

danielbeaudreau commented 3 years ago

Hi Max, re: the warnings, you may ignore those.

This looks like a bug. I believe the adapter cannot run on Windows at the moment, there seems to be a compatibility bug with the Gradle setup and windows.

maxirodr commented 3 years ago

@danielbeaudreau thank you for the answer :(

so for now this thread is closed. Thanks!

maxirodr commented 3 years ago

@danielbeaudreau if is it possible to talk with you outside here (because i've a few questions more), reach me at: https://privnote.com/JwsLJwcI#8OP44hB0v

thanks!

danielbeaudreau commented 3 years ago

Hi, if you have any other questions, you could ask them in this bug