search

GoogleCloudPlatform / healthcare-federated-access-services

Apache License 2.0
25 stars 9 forks source link

Force removal of config objects affecting existing testing personas #22

Open monicavalluri opened 4 years ago

monicavalluri commented 4 years ago

A few months ago we were able to delete NIH passport issuer and we would get server error with testPersonas return object, meaning that removal of the passport issuer would break one or multiple of the existing testing personas. We were required to provide confirmation dialog to support force delete. Is this still a case?

cdvoisin commented 4 years ago

Just checking in to see if this is still reproducible? Do you have a test case that you could share?

mpanik commented 4 years ago

This was our e2e test https://github.com/DNAstack/ddap-dam-admin/blob/master/e2e-tests/src/main/java/com/dnastack/ddap/frontend/AdminPassportIssuersE2eTest.java#L70-L85 which we were using a long time ago. I feel like this issue is more like the double check if the feature was removed intentionally or not.