GoogleCloudPlatform / healthcare-federated-access-services

Apache License 2.0
25 stars 9 forks source link

Style info_release page #28

Closed mpanik closed 4 years ago

mpanik commented 4 years ago

screenshot-localhost_8082-2020 04 27-16_27_33

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

mpanik commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

chaopeng commented 4 years ago

Seeing issues on low resolution.

  1. on Mac 1080p (which on my external monitor), see screenshot 1, some texts are overlap
  2. on more low resolution, linux 1536*864 (which we use on remote desktop), releasing item texts are overlap and the main div is bigger than page

I thing we need to fix issue 1, issue 2 maybe ok if it is hard to fix

screenshot 1:

1

screenshot 2:

2

mpanik commented 4 years ago

@chaopeng I did fix those overlapping labels, this should not be a problem anymore (let me know if is). I have also tried to improve responsiveness for smaller screens, but this is definitely not mobile friendly.