search

GoogleCloudPlatform / healthcare-federated-access-services

Apache License 2.0
25 stars 9 forks source link

Add AWS target adapter and key GC #33

Closed mbarkley closed 4 years ago

mbarkley commented 4 years ago

@cdvoisin I've added some comments in-line calling out some changes that may be particularly interesting to you.

mbarkley commented 4 years ago

@cdvoisin @chaopeng can one of you share the build failure? I don't see any test failures using the runtest.bash script locally.

mbarkley commented 4 years ago

Updated the PR to inject dependencies into the CreateAdapters method that can be passed into individual adapter constructor functions. I modelled the Options struct that's passed in after the struct of the same name used to initialise new DAM instances.

chaopeng commented 4 years ago

lgtm, @cdvoisin ptal

mbarkley commented 4 years ago

@chaopeng I've addressed @cdvoisin's last two change requests.