search

GoogleCloudPlatform / healthcare-federated-access-services

Apache License 2.0
25 stars 9 forks source link

Implement RemoveServiceAccount in AWS warehouse #48

Closed mbarkley closed 4 years ago

mbarkley commented 4 years ago

Implementation and unit tests for the RemoveServiceAccount method on the AWS warehouse.

mbarkley commented 4 years ago

@chaopeng updated with most of the changes you suggested. Please see my comment in-line about the order of operations in RemoveServiceAccount and let me know if that sounds good to you or if there is something you were saying that I missed.

chaopeng commented 4 years ago

lgtm, @cdvoisin ptal.