GoogleCloudPlatform / ide-login

The plugins-login-common library for authenticating with the Google Cloud Platform shared by several IDE plugins including Google Cloud Tools for Eclipse, Google Cloud Tools for IntelliJ, and Android Studio.
Apache License 2.0
2 stars 9 forks source link

Stored OAuth scopes don't need to be in a sorted set #14

Closed akerekes closed 8 years ago

akerekes commented 8 years ago

com.google.cloud.tools.ide.login.GoogleLoginState.oAuthScopes is a SortedSet, but the ordering provided by the contract of the interface is not used anywhere. It is used in a comparison calling equals(), but that's implemented by AbstractSet, it does not utilize ordering.

https://github.com/GoogleCloudPlatform/ide-login/blob/master/src/main/java/com/google/cloud/tools/ide/login/GoogleLoginState.java#L65