Persist multiple accounts

GoogleCloudPlatform / ide-login

The plugins-login-common library for authenticating with the Google Cloud Platform shared by several IDE plugins including Google Cloud Tools for Eclipse, Google Cloud Tools for IntelliJ, and Android Studio.

Apache License 2.0

2 stars 9 forks source link

Persist multiple accounts #29

Closed chanseokoh closed 7 years ago

chanseokoh commented 7 years ago

Fixes #23.

Most of the changes are in JavaPreferenceOAuthDataStore:
- Previously, the preference root node recorded an email address with the key EMAIL, which could be null.
- Now, each email address becomes the name of a child node. (Therefore, an email cannot be empty or null.)
Changes in GoogleLoginState are only about doing things in a for loop.

briandealwis commented 7 years ago

LGTM. There seems to be one missing piece: to be able to remove a single saved account. Currently we can only discard all accounts.