Closed chanseokoh closed 6 years ago
For future reference:
pom.xml
that need to be updated as well.I thought the package name was in sync with the group ID?
On Tue, Feb 7, 2017 at 2:56 PM, Chanseok Oh notifications@github.com wrote:
FTR:
- If the GitHub repo is to be renamed, there are several URL references in pom.xml that need to be updated as well.
- Make the default application name https://github.com/GoogleCloudPlatform/ide-login/blob/master/src/main/java/com/google/cloud/tools/login/GoogleLoginState.java#L91 in sync with the artifact ID.
- Make the package name in sync with the group ID.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/ide-login/issues/45#issuecomment-278121210, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9X6DrFinqkjrgT0FZ0wsVznjryqGIQks5raMxjgaJpZM4L4hHr .
-- Elliotte Rusty Harold elharo@macfaq.com
Yes, it's in sync. The above comment is for future reference.
I'll update the comment to be clearer.
This appears to be done except for the repo name which we won't change.
The login is not only for IDE. I think we have no problem changing the group ID (as well as the package name) at this stage, since we've never published this to Maven Central. Probably, CT4E is the only client at the moment.