search

GoogleCloudPlatform / ide-login

The plugins-login-common library for authenticating with the Google Cloud Platform shared by several IDE plugins including Google Cloud Tools for Eclipse, Google Cloud Tools for IntelliJ, and Android Studio.
Apache License 2.0
2 stars 9 forks source link

Guava 21.0 #55

Closed elharo closed 6 years ago

elharo commented 6 years ago

@chanseokoh @briandealwis

patflynn commented 6 years ago

@etanshaul @ivanporty @nbashirbello to verify this is compatible with IJ (which bundles a version of guava)

etanshaul commented 6 years ago

intellij is fine (it bundles v21). see https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/549 for thread where we updated the core lib

codecov[bot] commented 6 years ago

Codecov Report

Merging #55 into master will increase coverage by 0.95%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   80.56%   81.52%   +0.95%     
==========================================
  Files          10       10              
  Lines         247      276      +29     
  Branches       21       22       +1     
==========================================
+ Hits          199      225      +26     
- Misses         42       44       +2     
- Partials        6        7       +1
Impacted Files Coverage Δ
...loud/tools/login/JavaPreferenceOAuthDataStore.java 98.24% <0%> (+0.09%) :arrow_up:
...com/google/cloud/tools/login/GoogleLoginState.java 76.31% <0%> (+2.5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8122987...d3d4e60. Read the comment docs.