GoogleCloudPlatform / ide-login

The plugins-login-common library for authenticating with the Google Cloud Platform shared by several IDE plugins including Google Cloud Tools for Eclipse, Google Cloud Tools for IntelliJ, and Android Studio.
Apache License 2.0
2 stars 9 forks source link

upgrade guava #57

Closed elharo closed 6 years ago

elharo commented 6 years ago

@loosebazooka Tried upgrading mockito too but that failed.

patflynn commented 6 years ago

@etanshaul is this compatible with intellij?

codecov[bot] commented 6 years ago

Codecov Report

Merging #57 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files          10       10           
  Lines         276      276           
  Branches       22       22           
=======================================
  Hits          225      225           
  Misses         44       44           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40d5331...e660e85. Read the comment docs.

etanshaul commented 6 years ago

IJ 2018.1 is using Guava 21 still..

However, I don't believe IntelliJ is using this library. Instead, its using a bundled google.gdt.eclipse.login.common.jar jar

etanshaul commented 6 years ago

I am not aware of the history with that jar, but I'm looking to see if it makes sense to use this library instead. Anyone aware of why IJ was using the bundled jar in the first place?

chanseokoh commented 6 years ago

@etanshaul no matter why IJ was using the bundled jar, I think there is no particular reason that prevents using this library. However, from what I remember when I looked into the IJ code in the past, the IJ code has diverged a lot from this library, and it may be difficult to switch to use this library.