Closed elharo closed 6 years ago
@etanshaul is this compatible with intellij?
Merging #57 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 10 10
Lines 276 276
Branches 22 22
=======================================
Hits 225 225
Misses 44 44
Partials 7 7
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 40d5331...e660e85. Read the comment docs.
IJ 2018.1 is using Guava 21 still..
However, I don't believe IntelliJ is using this library. Instead, its using a bundled google.gdt.eclipse.login.common.jar
jar
I am not aware of the history with that jar, but I'm looking to see if it makes sense to use this library instead. Anyone aware of why IJ was using the bundled jar in the first place?
@etanshaul no matter why IJ was using the bundled jar, I think there is no particular reason that prevents using this library. However, from what I remember when I looked into the IJ code in the past, the IJ code has diverged a lot from this library, and it may be difficult to switch to use this library.
@loosebazooka Tried upgrading mockito too but that failed.