GoogleCloudPlatform / iot-device-sdk-embedded-c

Cloud IoT Device SDK for Connectivity to IoT Core.
Other
247 stars 83 forks source link

x86 specific build flag not cross platform #86

Closed sheindel closed 4 years ago

sheindel commented 5 years ago

This build flag causes issues when building for non-x86 build targets. Should be removed and referenced in platform specific wolfssl build configs

https://github.com/GoogleCloudPlatform/iot-device-sdk-embedded-c/blob/a26ee5ec79ad61eaf58461a1ef870f217e08b9d4/make/mt-config/mt-tls-wolfssl.mk#L30

sheindel commented 5 years ago

To be clear, wolfssl does configure this way via autoconf when on an x86 target, so this should be moved to any x86 target platforms or else the library will not work due to a misconfiguration of wolfssl and libiotc. In this case, osx and linux are safe bets. freertos and zephyr are expected to target embedded platforms which are almost certainly non-x86 targets and their makefiles can configure wolfssl appropriately.

sheindel commented 4 years ago

Resolved with PR https://github.com/GoogleCloudPlatform/iot-device-sdk-embedded-c/pull/88