Closed ssvir closed 4 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
I have a big-picture concern about this PR: Is someone also rewriting the other IAM code samples in this repo to use the GAPIC libraries?
If so, that's great! This migration is long overdue.
If not, I don't think we should merge this PR. It would be extremely confusing if some pages in the IAM docs told you to use the Google API Client Library for Java, and other pages told you to use the Cloud Client Library for Java. We need to update all of the samples for each language, not just some of them.
Hey @hegemonic ! Thanks for your vigilance in this regard :) I'm happy to inform that it's a coordinated effort to move all Java and Python IAM samples that are still using the old libraries to the new ones. Please reach out to me if you're interested in more details.
@m-strzelczyk Fantastic! Very glad to hear it 😀
Can you let me know when you're mostly done with the IAM samples, so that we can update the client libraries page as well?
Description
Fixes
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only