Closed msilc closed 3 months ago
IMHO this should be moved out from iam/api-client to iam/cloud-client. @Sita04 please advise.
Agreed it should be moved out of api-client folder. We have an existing folder for GAPIC samples under iam/snippets
Kindly consider creating a new sub-folder and moving these.
We should also make note to update doc references for the samples.
@hegemonic for visibility.
IMHO this should be moved out from iam/api-client to iam/cloud-client. @Sita04 please advise.
Agreed it should be moved out of api-client folder. We have an existing folder for GAPIC samples under
iam/snippets
Kindly consider creating a new sub-folder and moving these. We should also make note to update doc references for the samples.@hegemonic for visibility.
Should only the updated snippets or the entire iam/api-client be moved to the new folder?
IMHO this should be moved out from iam/api-client to iam/cloud-client. @Sita04 please advise.
Agreed it should be moved out of api-client folder. We have an existing folder for GAPIC samples under
iam/snippets
Kindly consider creating a new sub-folder and moving these. We should also make note to update doc references for the samples. @hegemonic for visibility.Should only the updated snippets or the entire iam/api-client be moved to the new folder?
Only the snippets that are updated should be moved to the iam/snippets
folder. Thanks!
Here is the summary of changes.
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run
label or use the checkbox below:
@msilc Kindly fix the failed tests.
Description
Service accounts snippets rewrote using a new library
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only