GoogleCloudPlatform / java-docs-samples

Java and Kotlin Code samples used on cloud.google.com
https://cloud.google.com/java
Apache License 2.0
1.76k stars 2.83k forks source link

fix: Adding missing grpc dependency #9294

Closed surbhigarg92 closed 6 months ago

surbhigarg92 commented 6 months ago

This PR adds the missing dependency io.grpc:grpc-census for OpenCensus Spanner Samples.

GRPC metrics was not getting captured and exported to stackdriver because of this missing dependency. Adding dependency to opencensus-contrib-grpc-metrics only allows enabling of GRPC metrics, but io.grpc:grpc-census is required for capturing metrics data.

suztomo commented 6 months ago

Would you fill the description about what it enables?

Sita04 commented 6 months ago

@surbhigarg92 LGTM, Before merging, kindly address @suztomo's comments.

suztomo commented 6 months ago

Would you fill the pull request description about what it enables for those who read this in future?

(What was not working?)