Closed kongweihan closed 2 months ago
Here is the summary of changes.
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run
label or use the checkbox below:
Hello, Please address the following questions:
- We ask to have a single code sample per file. This code looks like showing two code samples. What is this code sample demonstrates?
- This code sample does not have regional tags. What documentation use it?
- We do not host code samples without tests. What is a reason for lack of tests?
I think I've resolved the above comments. Any more thoughts on this? @minherz Thanks!
@minherz Is there any other comments that I can address? Thank you!
lgtm. please review this regional tag in http://devrel if you have access
What do you mean by reviewing it in http://devrel? IIUC after submit I'll notify our tech writer about the tags.
There're 2 pending reviewers in this PR, do you know how may I contact these reviewers? Thanks!
What do you mean by reviewing it in http://devrel? IIUC after submit I'll notify our tech writer about the tags.
I mean that the product (first word in the tag) is a registered product and there is no duplication or overlap with other code samples using the same region tag.
There're 2 pending reviewers in this PR, do you know how may I contact these reviewers? Thanks!
I think that first matter of business should be to fix all failed Kokoro checks. You can ping @billyjacobson in the comment after that.
Description
Add a batch write flow control example for Bigtable
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only