GoogleCloudPlatform / java-docs-samples

Java and Kotlin Code samples used on cloud.google.com
https://cloud.google.com/java
Apache License 2.0
1.76k stars 2.82k forks source link

Add a batch write flow control example for Bigtable #9314

Closed kongweihan closed 2 months ago

kongweihan commented 5 months ago

Description

Add a batch write flow control example for Bigtable

Checklist

snippet-bot[bot] commented 3 months ago

Here is the summary of changes.

You are about to add 3 region tags. - [bigtable/beam/batch-write-flow-control-example/src/main/java/bigtable/BatchWriteFlowControlExample.java:19](https://github.com/kongweihan/java-docs-samples/blob/a14b37d54a8e634f449625b31032142cf4dae8ed/bigtable/beam/batch-write-flow-control-example/src/main/java/bigtable/BatchWriteFlowControlExample.java#L19), tag `bigtable_beam_batch_write_flow_control_imports` - [bigtable/beam/batch-write-flow-control-example/src/main/java/bigtable/BatchWriteFlowControlExample.java:110](https://github.com/kongweihan/java-docs-samples/blob/a14b37d54a8e634f449625b31032142cf4dae8ed/bigtable/beam/batch-write-flow-control-example/src/main/java/bigtable/BatchWriteFlowControlExample.java#L110), tag `bigtable_beam_batch_write_flow_control_cloudbigtableio` - [bigtable/beam/batch-write-flow-control-example/src/main/java/bigtable/BatchWriteFlowControlExample.java:134](https://github.com/kongweihan/java-docs-samples/blob/a14b37d54a8e634f449625b31032142cf4dae8ed/bigtable/beam/batch-write-flow-control-example/src/main/java/bigtable/BatchWriteFlowControlExample.java#L134), tag `bigtable_beam_batch_write_flow_control_bigtableio`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

kongweihan commented 3 months ago

Hello, Please address the following questions:

  1. We ask to have a single code sample per file. This code looks like showing two code samples. What is this code sample demonstrates?
  2. This code sample does not have regional tags. What documentation use it?
  3. We do not host code samples without tests. What is a reason for lack of tests?

I think I've resolved the above comments. Any more thoughts on this? @minherz Thanks!

kongweihan commented 3 months ago

@minherz Is there any other comments that I can address? Thank you!

kongweihan commented 2 months ago

lgtm. please review this regional tag in http://devrel if you have access

What do you mean by reviewing it in http://devrel? IIUC after submit I'll notify our tech writer about the tags.

There're 2 pending reviewers in this PR, do you know how may I contact these reviewers? Thanks!

minherz commented 2 months ago

What do you mean by reviewing it in http://devrel? IIUC after submit I'll notify our tech writer about the tags.

I mean that the product (first word in the tag) is a registered product and there is no duplication or overlap with other code samples using the same region tag.

There're 2 pending reviewers in this PR, do you know how may I contact these reviewers? Thanks!

I think that first matter of business should be to fix all failed Kokoro checks. You can ping @billyjacobson in the comment after that.