GoogleCloudPlatform / java-docs-samples

Java and Kotlin Code samples used on cloud.google.com
https://cloud.google.com/java
Apache License 2.0
1.74k stars 2.82k forks source link

docs(samples): Add snippets for Apache Iceberg using Managed I/O #9339

Closed VeronicaWasson closed 1 month ago

VeronicaWasson commented 2 months ago

Description

Add code snippets for reading and writing to Apache Iceberg using the Dataflow managed I/O transform.

Fixes doc bug: b/341806230 (part of the work for b/338063763)

Checklist

snippet-bot[bot] commented 2 months ago

Here is the summary of changes.

You are about to add 2 region tags. - [dataflow/snippets/src/main/java/com/example/dataflow/ApacheIcebergRead.java:19](https://github.com/VeronicaWasson/java-docs-samples/blob/82be524623c67488addc7cba568d032df2470146/dataflow/snippets/src/main/java/com/example/dataflow/ApacheIcebergRead.java#L19), tag `dataflow_apache_iceberg_read` - [dataflow/snippets/src/main/java/com/example/dataflow/ApacheIcebergWrite.java:19](https://github.com/VeronicaWasson/java-docs-samples/blob/82be524623c67488addc7cba568d032df2470146/dataflow/snippets/src/main/java/com/example/dataflow/ApacheIcebergWrite.java#L19), tag `dataflow_apache_iceberg_write`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

VeronicaWasson commented 1 month ago

LGTM. A small request: please use two region tag declarations to exclude the main method from the code snippet.

The main method is the main body of the snippets though. Dataflow code tends to be longish because it builds a pipeline. e.g. see https://cloud.google.com/dataflow/docs/guides/write-to-pubsub#examples