GoogleCloudPlatform / java-docs-samples

Java and Kotlin Code samples used on cloud.google.com
https://cloud.google.com/java
Apache License 2.0
1.74k stars 2.82k forks source link

chore: comment about how to instantiate logger variable in Cloud Run #9340

Closed suztomo closed 2 months ago

suztomo commented 2 months ago

This App.java is referenced in https://cloud.google.com/run/docs/samples/cloudrun-manual-logging#cloudrun_manual_logging-java. But the document does not explain how to instantiate and configure the logger variable.

https://cloud.google.com/run/docs/logging#run_manual_logging-java has the answer. So let's add the explanation in the source code comment.

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

suztomo commented 2 months ago

@iennae Thank you for quick response. Now I see https://cloud.google.com/run/docs/samples/cloudrun-manual-logging#cloudrun_manual_logging-java has been updated. Good.