GoogleCloudPlatform / java-docs-samples

Java and Kotlin Code samples used on cloud.google.com
https://cloud.google.com/java
Apache License 2.0
1.75k stars 2.82k forks source link

fix(spanner): Explicit declaration of dependencies for OpenTelemetry traces sample #9409

Closed nareshz closed 1 month ago

nareshz commented 1 month ago

This PR includes changes to add all the required dependencies for OpenTelemetry traces sample explicitly.

Sita04 commented 1 month ago

@minherz PTAL at these changes.

nareshz commented 1 month ago

@olavloite Can you PTAL at your convenience?

nareshz commented 1 month ago

what is a reason for adding all these dependencies? is it the best practice to be followed?

Yes, right. The reason is mainly to follow good practice of explicitly declaring all the dependencies required.

minherz commented 1 month ago

what is a reason for adding all these dependencies? is it the best practice to be followed?

Yes, right. The reason is mainly to follow good practice of explicitly declaring all the dependencies required.

I am not aware of such good practice. Can you please reference me to Google documentation that defines it? If not, please provide another widely accepted guidance reference.

Thank you