Closed msampathkumar closed 1 week ago
Update: Waiting for CICD check to complete
Here is the summary of changes.
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run
label or use the checkbox below:
Hi @minherz - Updated the summary with bug ticket.
I don't understand something here! I believed that snippet-bot test @ https://github.com/GoogleCloudPlatform/java-docs-samples/pull/9421/checks?check_run_id=28104747679 is to prevent that degradation of user experience
. Kindly help me understand.
Hi @minherz - Updated the summary with bug ticket.
I don't understand something here! I believed that snippet-bot test @ https://github.com/GoogleCloudPlatform/java-docs-samples/pull/9421/checks?check_run_id=28104747679 is to prevent that
degradation of user experience
. Kindly help me understand.
Thank you for providing the reasoning behind this change. The description of the linked issue states "After updating the Cloud Docs pages, we need to identify & clear unwanted region tags.".
I did a quick check and indeed majority of the region tags with the generativeaionvertexai_
prefix are represented in the document while the region tags with the suffix aiplatform_
appear only in the Sample Browser. However, I found that the generativeaionvertexai_gemini_single_turn_multi_image
region tag does not appear in any documentation. Removing its older version (aiplatform_gemini_single_turn_multi_image
) means the documentation degrades.
I also see that the region tag generativeaionvertexai_gemini_get_started
is not mentioned in the documentation nor in Sample Browser.
Please, address these two region tags before removing their older versions. There are two options to handle it:
Reassigning to @msampathkumar to remaining address comments.
Update: I have marked the following region tags for deprecation.
region tags with the suffix aiplatform_ appear only in the Sample Browser.
Working on a fresh PR with more changes.
Adding
generativeaionvertexai_
region tags to replace oldaiplatform_
In near future GenAI code samples, will only use
generativeaionvertexai_
region tag prefix.Description
Fixes b/355457593
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist