GoogleCloudPlatform / java-docs-samples

Java and Kotlin Code samples used on cloud.google.com
https://cloud.google.com/java
Apache License 2.0
1.76k stars 2.83k forks source link

security-command-center: no code samples for managing security marks on assets #9593

Open hegemonic opened 6 hours ago

hegemonic commented 6 hours ago

In which file did you encounter the issue?

https://github.com/GoogleCloudPlatform/java-docs-samples/tree/dd24a493/security-command-center/snippets/src/main/java/vtwo/marks

Did you change the file? If so, how?

no

Describe the issue

There are no code samples that show how to use Security Command Center v2 to manage security marks for assets. We only have code samples for security marks on findings.

We need v2 equivalents of several v1 snippets from this file: https://github.com/googleapis/google-cloud-java/blob/cff95fd0631777a9a8f077848c39d458c7e5b339/google-cloud-examples/src/main/java/com/google/cloud/examples/securitycenter/snippets/SecurityMarkSnippets.java

Specifically, we need v2 equivalents of the samples with the following region tags:

cc: @owenhuyn

owenhuyn commented 6 hours ago

Asset APIs are not carried over to the V2 API as they are deprecated. Hence security marks are only for findings in the V2 API. This is by design and we don't need V2 equivalents of asset samples that are currently in V1.

hegemonic commented 4 hours ago

I discussed this offline with @owenhuyn, and he agreed that security marks for assets are supported in the v2 API. Other methods related to assets are not supported in v2.

For example, see the organizations.assets.updateSecurityMarks method in the SCC v2 API.