search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Fixes support for TcpRoute in the AppNet APIs #143

Closed bowei closed 1 year ago

bowei commented 1 year ago 
Fix various bugs needed to make TcpRoute resource work

- Operations needs to be implemented
- Various mismatches in the interface with the compute API
google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bowei commented 1 year ago

This should be ready for review

aojea commented 1 year ago

mostly questions for self education

aojea commented 1 year ago

/lgtm