search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

add error test cases for transitive closure #147

Closed kl52752 closed 9 months ago

google-oss-prow[bot] commented 11 months ago

Hi @kl52752. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kl52752 commented 11 months ago

/assign @bowei

kl52752 commented 10 months ago

/ok-to-test

kl52752 commented 9 months ago

/cc @mag-kol //cc @tangenti

google-oss-prow[bot] commented 9 months ago

@kl52752: GitHub didn't allow me to request PR reviews from the following users: mag-kol.

Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/pull/147#issuecomment-1849888493): >/cc @mag-kol >//cc @tangenti Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bowei commented 9 months ago

/lgtm /approve

google-oss-prow[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/rgraph-unstable/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment