search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

add tcp route #148

Closed kl52752 closed 8 months ago

kl52752 commented 10 months ago

Add AppNet Tcp Route resource to rGraph

google-oss-prow[bot] commented 10 months ago

Hi @kl52752. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bowei commented 9 months ago

This mostly looks good -- but seems like we have to get the other changes in first.

kl52752 commented 9 months ago

This mostly looks good -- but seems like we have to get the other changes in first.

yes, that's why this PR is marked as wip. It is dependent on PlaceholderType and ActionUpdate.

kl52752 commented 9 months ago

This mostly looks good -- but seems like we have to get the other changes in first.

PlaceholderType PR was merged, I applied those changes. It is now ready to review

bowei commented 8 months ago

/ok-to-test

kl52752 commented 8 months ago

cc/ @mag-kol

bowei commented 8 months ago

/lgtm /approve

google-oss-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/rgraph-unstable/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment