search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Update golang api version, add RegionSslPolicies service #154

Closed panslava closed 11 months ago

panslava commented 1 year ago

I need that to support SslPolicies for regional XLB in ingress-gce

/assign @bowei @spencerhance @swetharepakula

google-oss-prow[bot] commented 1 year ago

Hi @panslava. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kl52752 commented 1 year ago

/ok-to-test

swetharepakula commented 1 year ago

/approve

bowei commented 1 year ago

Need to split into 3 commits:

spencerhance commented 1 year ago

/hold

panslava commented 12 months ago

Need to split into 3 commits:

  • go mod
  • vendor
  • Add to meta/

Done split, ready for review :)

spencerhance commented 12 months ago

/unhold

bowei commented 11 months ago

/lgtm /approve

google-oss-prow[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, panslava, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment