search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Add support for all array elements #156

Closed kl52752 closed 11 months ago

kl52752 commented 1 year ago

When defining type traits we needed a way to match all arrays indexes to access arrays struct's fields.

As an example why this change is needed and how it will be used I added Backend Service support where Backends, an array which is required, has some optional fields.

kl52752 commented 1 year ago

/assign @bowei /cc @yazanri

google-oss-prow[bot] commented 1 year ago

@kl52752: GitHub didn't allow me to request PR reviews from the following users: yazanri.

Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/pull/156#issuecomment-1820384298): >/assign @bowei >/cc @yazanri Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bowei commented 1 year ago

split off the change for backendservice into a separate commit

kl52752 commented 1 year ago

split off the change for backendservice into a separate commit

done, I will post PR with BS changes after this one is closed.

bowei commented 11 months ago

Make sure you update your commit comment to match the updated code

kl52752 commented 11 months ago

Make sure you update your commit comment to match the updated code

done

kl52752 commented 11 months ago

@bowei I added support for Map indices. At first I thought that I will do this in new PR but since you mentioned it in some comment I added functions + tests for that. PTAL

bowei commented 11 months ago

/lgtm /approve

google-oss-prow[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/rgraph-unstable/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment