search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Add action update #157

Closed kl52752 closed 8 months ago

kl52752 commented 10 months ago

Implement generic action for Action Update

kl52752 commented 10 months ago

/asign @bowei /cc @yazanri

google-oss-prow[bot] commented 10 months ago

@kl52752: GitHub didn't allow me to request PR reviews from the following users: yazanri.

Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/pull/157#issuecomment-1822883550): >/asign @bowei >/cc @yazanri Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kl52752 commented 10 months ago

/assign @bowei

bowei commented 10 months ago

Commit message does not contain much information about this change. Please repush with a detailed commit message on what this change does.

kl52752 commented 10 months ago

Commit message does not contain much information about this change. Please repush with a detailed commit message on what this change does.

updated. I added changes in health check to test this in cloud. Do you want me to split those changes?

bowei commented 10 months ago

Make them separate commits.

kl52752 commented 10 months ago

Make them separate commits.

done

kl52752 commented 9 months ago

/cc @mag-kol

google-oss-prow[bot] commented 9 months ago

@kl52752: GitHub didn't allow me to request PR reviews from the following users: mag-kol.

Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/pull/157#issuecomment-1849858425): >/cc @mag-kol > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kl52752 commented 9 months ago

/cc tangenti

google-oss-prow[bot] commented 9 months ago

@kl52752: GitHub didn't allow me to request PR reviews from the following users: tangenti.

Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/pull/157#issuecomment-1849864271): >/cc tangenti Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kl52752 commented 9 months ago

/cc tangenti

kl52752 commented 8 months ago

cc/ @mag-kol

kl52752 commented 8 months ago

/retest

bowei commented 8 months ago

/lgtm /approve

google-oss-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/rgraph-unstable/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment