search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

add PlaceholderType #158

Closed kl52752 closed 11 months ago

kl52752 commented 12 months ago

PlaceholderType is used to represent GCE resource type versions that either don't exist (e.g. there is not alpha version of the given resource) or we do not intend to use (e.g. we omitted the type/version from being included in pkg/cloud/meta).

kl52752 commented 12 months ago

/assign @bowei

bowei commented 11 months ago

Fix the title of this PR and the commit message to match the new code and renamed types, etc.

bowei commented 11 months ago

See comment -- you need to fix the commit message and the PR title.

kl52752 commented 11 months ago

See comment -- you need to fix the commit message and the PR title.

done

bowei commented 11 months ago

This is close, please address the comments.

bowei commented 11 months ago

/lgtm /approve

google-oss-prow[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/rgraph-unstable/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment