search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Add check that Alpha and Beta are subsets of GA fields #166

Closed kl52752 closed 8 months ago

kl52752 commented 9 months ago

Extend CheckSchema function with Assertion that Alpha and Beta types are subsets of GA.

kl52752 commented 9 months ago

/assign @bowei

kl52752 commented 8 months ago

cc/ @tangenti

kl52752 commented 8 months ago

cc/ @mag-kol

bowei commented 8 months ago

ping, this PR is close.

kl52752 commented 8 months ago

ping, this PR is close.

Do you want me to rebase this PR to master branch?

bowei commented 8 months ago

Yes, rebase to master.

kl52752 commented 8 months ago

Yes, rebase to master.

master branch is missing few commits from rgraph-unstable,. Can we merge this PR to rgraph and then I will prepare merge rgraph to master.

bowei commented 8 months ago

/lgtm /approve

google-oss-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/rgraph-unstable/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment