search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Add bosko project handler for e2e tests. #170

Closed kl52752 closed 8 months ago

google-oss-prow[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kl52752 Once this PR has been reviewed and has the lgtm label, please assign bowei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kl52752 commented 10 months ago

cc/ @tangenti cc/ @mag-kol assign/ @bowei

aojea commented 10 months ago

you should use the trick of of a tools.go file to not bring the dependencies to the project and only use them for testing

https://github.com/kubernetes/kubernetes/commit/f981628ce897a96a8a08a2a21c4d6bdb41601fbd https://github.com/kubernetes/ingress-gce/tree/master/hack/tools

bowei commented 10 months ago

Can we fix the dependencies issue? This is pulling in a huge number of files.

bowei commented 9 months ago

Ping on this change...

bowei commented 8 months ago

Ping.

kl52752 commented 8 months ago

Bosko project is not needed anymore for setting up the e2e test grid. Closing this PR