search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Extract CheckStructuralSubset implementation. #171

Closed kl52752 closed 8 months ago

kl52752 commented 8 months ago

CheckStructuralSubset function has path passed for better error reporting. This implementation detail shouldn't be exposed in public API.

kl52752 commented 8 months ago

/assign @bowei

bowei commented 8 months ago

/lgtm /approve

google-oss-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment