search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Deep copy path in Differ Results #173

Closed kl52752 closed 7 months ago

kl52752 commented 7 months ago

Differ returns a Results list of all paths that mismatch. The list is a pair of paths and status. The path is of type slice of strings. We need to deep copy the path otherwise it will be overridden in the next iteration and as a result we will get all paths pointing to the same value.

kl52752 commented 7 months ago

cc/ @AwesomePatrol

kl52752 commented 7 months ago

assign/ @bowei

bowei commented 7 months ago

Commit comments need to be more descriptive

One line summary

Longer description.

Please follow format from https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53

kl52752 commented 7 months ago

Updated @bowei PTAL

bowei commented 7 months ago

You added some extra whitespace -- please remove next time.

/lgtm /approve

google-oss-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment