search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

implement Action Update for AppNet TCPRoute #179

Closed kl52752 closed 6 months ago

kl52752 commented 6 months ago
kl52752 commented 6 months ago

/cc @AwesomePatrol /cc @mag-kol

/assign @bowei

google-oss-prow[bot] commented 6 months ago

@kl52752: GitHub didn't allow me to request PR reviews from the following users: AwesomePatrol.

Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/pull/179#issuecomment-2014900346): >/cc @AwesomePatrol >/cc @mag-kol > >/assign @bowei Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bowei commented 6 months ago

Please clean up the commits:

You have changes to the main logic, add errors.go etc but the commit description is "Create e2e tests for TCPRoute Update Action" with no description.

Split the commit into pieces that are more self-contained and update the one line message and the description appropriately.

It is important that we keep the commits in the codebase meaningful as it is a form of documentation as well for the history of the changes.

kl52752 commented 6 months ago

Please clean up the commits:

You have changes to the main logic, add errors.go etc but the commit description is "Create e2e tests for TCPRoute Update Action" with no description.

Split the commit into pieces that are more self-contained and update the one line message and the description appropriately.

It is important that we keep the commits in the codebase meaningful as it is a form of documentation as well for the history of the changes.

fixed

bowei commented 6 months ago

Thanks for the revisions.

/lgtm /approve

google-oss-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment