search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Fix TCP Route test #183

Closed AwesomePatrol closed 5 months ago

AwesomePatrol commented 6 months ago

Previously, the tests relied on hardcoded names of NEGs created by neg-controller in GKE cluster. Now all e2e tests can be run without GKE.

AwesomePatrol commented 6 months ago

/cc @kl52752 /cc @akwi-github

/assign @bowei

google-oss-prow[bot] commented 6 months ago

@AwesomePatrol: GitHub didn't allow me to request PR reviews from the following users: akwi-github.

Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/pull/183#issuecomment-2034217248): >/cc @kl52752 >/cc @akwi-github > >/assign @bowei Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kl52752 commented 6 months ago

/lgtm

Ramkumar-K commented 5 months ago

/approve

kl52752 commented 5 months ago

/lgtm

akwi-github commented 5 months ago

/cc @mag-kol

bowei commented 5 months ago

/approve /lgtm

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, bowei, Ramkumar-K

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment