search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

e2e test - Backend service update #185

Closed akwi-github closed 5 months ago

akwi-github commented 5 months ago

Add e2e test for updating backend service.

akwi-github commented 5 months ago

/cc @AwesomePatrol

kl52752 commented 5 months ago

/lgtm /approve

akwi-github commented 5 months ago

/assign @bowei

bowei commented 5 months ago

Squash your commits and fix the commit message. You should use the following format:

https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53

bowei commented 5 months ago

/hold

akwi-github commented 5 months ago

Squash your commits and fix the commit message. You should use the following format:

https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53

Done. Do you have any other comments?

bowei commented 5 months ago

/hold remove

bowei commented 5 months ago

Changes look good. Thanks for fixing the commits.

/lgtm /approve

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akwi-github, bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bowei commented 5 months ago

/remove-hold