search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Fix BackendService update test #187

Closed akwi-github closed 5 months ago

akwi-github commented 5 months ago

Add meshName parameter to ensureMesh helper function

akwi-github commented 5 months ago

/cc @AwesomePatrol

kl52752 commented 5 months ago

Please change commit name to indicate what it actually does (the thing that is in comment, you can swap them :) ), beside that LGTM.

/lgtm

akwi-github commented 5 months ago

Please change commit name to indicate what it actually does (the thing that is in comment, you can swap them :) ), beside that LGTM.

/lgtm

Done.

akwi-github commented 5 months ago

/assign @bowei

kl52752 commented 5 months ago

/lgtm

kl52752 commented 5 months ago

/lgtm

bowei commented 5 months ago

/lgtm /approve

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akwi-github, AwesomePatrol, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment