search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Add Mesh with multiple tcproutes e2e test with diffing logic fix #191

Closed akwi-github closed 2 months ago

akwi-github commented 5 months ago

Setup 1) Create Mesh 2) Create multiple tcproutes and link them to the mesh 3) Create 2 backend services with healthcheck per tcproute and add them to tcproutes

Changes 1) Delete backend service 2) Delete 1 of tcproutes (a one that backend service was removed from)

Expectations 1) Ensure that changes affect only tcproutes they modify

b/332473866

akwi-github commented 5 months ago

/cc @kl52752

akwi-github commented 5 months ago

/hold

bowei commented 5 months ago

/approve

akwi-github commented 3 months ago

/retest

akwi-github commented 3 months ago

/hold-remove

akwi-github commented 3 months ago

/unhold

akwi-github commented 3 months ago

/retest

bowei commented 3 months ago

What is the next step here?

akwi-github commented 3 months ago

/retest

akwi-github commented 3 months ago

What is the next step here?

I am writing one pager with description of a small bug I found and proposed solution (however the fix breaks our unit tests, so it also need to be updated).

akwi-github commented 3 months ago

/retest

akwi-github commented 3 months ago

/cc @mag-kol

akwi-github commented 3 months ago

/cc @bowei

bowei commented 3 months ago

/approve /remove-lgtm

bowei commented 2 months ago

Can you rebase to get rid of the merge commit?

kl52752 commented 2 months ago

Please rebase and put your commits on top to get rid of merge commits https://screenshot.googleplex.com/3vXpW8QE4PsybEQ

akwi-github commented 2 months ago

/retest

akwi-github commented 2 months ago

Please rebase and put your commits on top to get rid of merge commits https://screenshot.googleplex.com/3vXpW8QE4PsybEQ

Done

bowei commented 2 months ago

/lgtm /approve

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akwi-github, bowei, mag-kol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment