search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Add Healthcheck update test #192

Closed akwi-github closed 5 months ago

akwi-github commented 5 months ago

Setup 1) Create tcproute 2) Create backend service 3) Create healthcheck for backend service 4) Connect backend service with tcproute

Changes 1) Update healthcheck

Expectations 1) Verify that action succeeded

b/332473784

akwi-github commented 5 months ago

/cc @AwesomePatrol /cc @kl52752

bowei commented 5 months ago

/approve

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akwi-github, AwesomePatrol, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bowei commented 5 months ago

Hmm -- I didn't want this to merge, but allow others to LGTM to merge this.

Please make the changes specified in the comments.

The "approve" was not meant to skip code review.

I will make sure to use the "hold" from now on.