search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

fix: Add MinimumRateLimiter configured to 50ms to e2e tests #195

Closed AwesomePatrol closed 5 months ago

AwesomePatrol commented 5 months ago

When running e2e tests in the CI pipeline, we often hit RATE_LIMIT_EXCEEDED error. The quota is 1200 requests per minute. 50ms minimum wait before making a request guarantees we won't hit it (60*1000 / 1200).

(leaking timer is not concern in tests and is fixed in go 1.23+)

Bug: b/336784945

AwesomePatrol commented 5 months ago

/assign @bowei /cc @kl52752 /cc @akwi-github

akwi-github commented 5 months ago

/lgtm

bowei commented 5 months ago

/lgtm /approve

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment