search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Remove latency measurements from TickerRateLimiter tests #206

Closed AwesomePatrol closed 5 months ago

AwesomePatrol commented 6 months ago

The first call returns without waiting for a full tick so it should take a minimum 490ms.

image

This would still be unreliable, so simplified the test to not rely on time.

AwesomePatrol commented 6 months ago

/retest /assign @kl52752

kl52752 commented 6 months ago

/lgtm /approve

Thanks for quick fix

AwesomePatrol commented 6 months ago

/assign @bowei

kl52752 commented 5 months ago

/lgtm /approve

bowei commented 5 months ago

/lgtm /approve

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, bowei, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment