search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Split TickerRateLimiter test #210

Closed AwesomePatrol closed 3 months ago

AwesomePatrol commented 3 months ago

One verifies that ticker fires at all, the other checks if context is checked. Otherwise it was nondeterministic which will be chosen (ticker or context).

AwesomePatrol commented 3 months ago

/cc @kl52752

kl52752 commented 3 months ago

/lgtm

bowei commented 3 months ago

/approve /lgtm

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment