search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Consistently log a message right after making a request #213

Closed AwesomePatrol closed 2 months ago

AwesomePatrol commented 2 months ago
  1. It increases log consistency (it unifies behavior with most other requests)
  2. It makes it easier to troubleshoot rate limiter / quota issues (rate limiter's Accept wait is no longer between log line and an actual request)
kl52752 commented 2 months ago

/lgtm

AwesomePatrol commented 2 months ago

/assign @bowei

bowei commented 2 months ago

/lgtm /approve

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment