search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Add BackendServiceMetadataUpdate test #217

Closed akwi-github closed 1 month ago

akwi-github commented 2 months ago

Backend service metadata update test

Setup

  1. Create HealthCheck
  2. Create BackendService with multiple keys in Metadata field and add HealthCheck to it

Changes

  1. Update BackendService Metadatas field by updating one of key-pair values
  2. Delete one of keys from the Metadatas field

Expectations

Each time expect that the comparison works properly

akwi-github commented 2 months ago

/cc @kl52752 /cc @mag-kol

akwi-github commented 1 month ago

One small nit, otherwise LGTM

Done.

akwi-github commented 1 month ago

/test pull-k8s-cloud-provider-test

AwesomePatrol commented 1 month ago

/retest

akwi-github commented 1 month ago

/retest

akwi-github commented 1 month ago

/retest

kl52752 commented 1 month ago

/lgtm /approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akwi-github, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[e2e/OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/e2e/OWNERS)~~ [kl52752] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment