search

GoogleCloudPlatform / k8s-cloud-provider

Support code for implementing a Kubernetes cloud provider for Google Cloud Platform
Apache License 2.0
37 stars 46 forks source link

Accept 400 as a valid error code for zone/region that does not exist #221

Closed AwesomePatrol closed 1 month ago

AwesomePatrol commented 1 month ago

GCE API started returning 400 instead of expected 404 in some cases. This is expected behavior. More details available in the bug.

Bug: b/361065819

AwesomePatrol commented 1 month ago

/cc @kl52752

kl52752 commented 1 month ago

/lgtm

kl52752 commented 1 month ago

/approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[e2e/OWNERS](https://github.com/GoogleCloudPlatform/k8s-cloud-provider/blob/master/e2e/OWNERS)~~ [kl52752] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment